Bugs
Bugs Taken in Planning
<bugzilla>
{
"component": "Gaia::Dialer",
"target_milestone": "2.0 S6 (18july)",
"whiteboard": "planned-sprint",
"whiteboard_type": "contains",
"include_fields": "id, assigned_to, summary, cf_blocking_b2g, cf_feature-b2g, whiteboard, status, resolution"
}
</bugzilla>
Bugs Taken but not Completed
<bugzilla>
{
"component": "Gaia::Dialer",
"whiteboard": "in-sprint=v2.0-S6",
"whiteboard_type": "contains",
"include_fields": "id, assigned_to, summary, cf_blocking_b2g, cf_feature-b2g, whiteboard, status, resolution"
}
</bugzilla>
Bugs Taken During Sprint
<bugzilla>
{
"component": "Gaia::Dialer",
"target_milestone": "2.0 S6 (18july)",
"whiteboard": "planned-sprint",
"whiteboard_type": "not_contains",
"include_fields": "id, assigned_to, summary, cf_blocking_b2g, cf_feature-b2g, whiteboard, status, resolution"
}
</bugzilla>
All Issues for this Sprint
<bugzilla>
{
"component": "Gaia::Dialer",
"target_milestone": "2.0 S6 (18july)",
"include_fields": "id, assigned_to, summary, cf_blocking_b2g, cf_feature_b2g, whiteboard, status, resolution"
}
</bugzilla>
Blockers Without an Assignee
<bugzilla>
{
"component": "Gaia::Dialer",
"cf_blocking_b2g": "+",
"cf_blocking_b2g_type": "contains",
"resolution": "---",
"assigned_to": "nobody@mozilla.org",
"include_fields": "id, assigned_to, summary, cf_blocking_b2g, cf_feature_b2g, whiteboard, status, resolution"
}
</bugzilla>
Bugs Redirected
<bugzilla>
{
"component": "Gaia::Dialer",
"component_type": "not_equals",
"whiteboard": "planned-sprint",
"whiteboard_type": "contains",
"target_milestone": "2.0 S6 (18july)",
"include_fields": "id, assigned_to, summary, cf_blocking_b2g, cf_feature_b2g, whiteboard, status, resolution"
}
</bugzilla>
Daily Meetings
- Current hosts: drs, gtorodelvalle, thills
- Hosts rotate every week.
- If you're not available for a standup that you're scheduled to host, then ask for someone else to host instead for just that time.
- Start by pinging everyone who should be participating.
- List any administrative items you have, and then ask for more from other people (look at the Etherpad).
- Look at the list of blockers and blocker nominations and see if there's anything new or that needs action. Mention these during this time.
- Move to individual updates. Go alphabetically, in descending order.
- If someone's update is taking longer than 3-4 minutes, you should generally cut them off and ask them to talk about it after the standup.
- Copy the reports from the GDoc to the wiki page for that day. Use the Etherpad-to-Wiki converter to format it. You can just copy and paste the whole thing and the converter will do everything for you.
- Ask the person who should be hosting the week after you if they'll be available. If not, move onto the next person.
Day 11: July 21
- Sprint extended by a day at the beginning due to a scheduling error.
Vidyo meeting, no minutes.
drs
- Admin:
- I did a bunch of prep for sprint planning.
- I still haven't had any feedback on StyleDocco! Please tell me your thoughts/comments.
- Next steps:
- bug 967440 - Remove some reflows on the keypad
- I failed to get this done last sprint, going to work on it soon.
- bug 1035183 - Matching numbers screen results is not properly localized for 10+ matches
- Backed out of 2.0 and waiting for bug 1018494 to be uplifted before re-uplifting it.
- bug 1021478 - [1.4] Set outgoing calls "Always ask" with two sim card inside, use bluetooth headset to dial, there will be no network message
- Wei is asking for more help.
- Done:
- bug 1027478 - Modify telephony API from dialEmergency(number, serviceId) to dialEmergency(number)
- Reviewed for Anthony, checkin+
- bug 1037637 - [DSDS][Dialer] No text on "select SIM" prompt for outgoing calls
- Reviewed for Gandalf, review+. Waiting for Anthony to feedback+.
- bug 1030912 - [B2G][Dialer][Bluetooth] While in a call the Speaker icon is shown instead of the Bluetooth Headset icon
- Landed branch patch for 1.4.
- bug 961154 - When a second incoming call occurs, it does not turn the screen on
- Reviewed for Anthony, sort of review+. Just a small refactor needed.
- bug 1010104 - [Dialer][Call Screen] Baseline of the contact name when applying the fluid font size
- Reviewed for Germán, review-
Rik
gtorodelvalle
- bug 1010104 - [Dialer][Call Screen] Baseline of the contact name when applying the fluid font size:
- Currently including Doug's comments in the patch.
- Implemented the new version with no getScenario() as suggested by Doug.
- Asked revision to Doug about the new version. New revision asked ;)
thills
pacorampas
Day 10: July 18
| Meeting Minutes
|
|
10:30 drs: hi everyone, I think it's time for our meeting
10:30 drs: gsvelto, Rik. thin crowd
10:30 gsvelto: hi there
10:30 drs: hey
10:31 drs: ok, so on the admin side:
10:31 Rik: yup
10:31 drs: I'm needinfoing people on dialer-most-wanted bugs to help with pre-planning for sprint planning on monday
10:31 drs: also I haven't had any feedback on styledocco yet from anyone
10:31 drs: so please give comments on that
10:32 drs: any more admin stuff from anyone else?
10:32 drs: ok, as for my update
10:32 Rik: nope
10:32 gsvelto: drs, I still have to figure out how styledocco works, I'm not very familiar with it :(
10:32 drs: I actually have nothing to highlight
10:33 drs: gsvelto: it's actually pretty easy, it's basically markdown in CSS comments
10:33 drs: anyways, next up is gsvelto
10:33 gsvelto: on my side not much dialer activity today
10:33 gsvelto: I reviewed thills patch for bug 1029721
10:33 firebot: https://bugzil.la/1029721 — FIXED, thills — CDMA call waiting call is not logged in call history
10:34 gsvelto: and mucked around a bit trying to fix the tests for bug 1006592
10:34 firebot: https://bugzil.la/1006592 — ASSIGNED, gsvelto — While sending USSD code, last dialed number by user appears in dialer app
10:34 gsvelto: and that's it, Rik?
10:34 Rik: we've had one our test failing because of a devtool landing
10:35 Rik: so this is the last straw, last week, I'll focus on getting our Gaia integration tests to be visible so that sheriffs can sheriff it
10:35 Rik: s/last week/next week/
10:35 drs: I didn't know they aren't
10:35 Rik: Gij is hidden
10:35 drs: ah
10:35 Rik: there's been discussion on dev.gaia about it
10:36 Rik: and that's it
10:36 drs: cool, well that's a wrap then
|
drs
- Admin:
- I'm going through the dialer-most-wanted bugs and needinfoing people who I think would be good to work on them or I'd like feedback from. This is to help with sprint planning coming up on Monday.
- I still haven't had any feedback on StyleDocco! Please tell me your thoughts/comments.
- Next steps:
- bug 1037637 - [DSDS][Dialer] No text on "select SIM" prompt for outgoing calls
- Need to review this for Gandalf.
- bug 967440 - Remove some reflows on the keypad
- Next thing to work on, this is my last bug for this sprint.
- Scoping out more long-term work. In particular, I'm focused on being able to simulate situations such as emergency calls in Mulet.
- bug 1035183 - Matching numbers screen results is not properly localized for 10+ matches
- Backed out of 2.0 and waiting for bug 1018494 to be uplifted before re-uplifting it.
- Done:
- bug 1030912 - [B2G][Dialer][Bluetooth] While in a call the Speaker icon is shown instead of the Bluetooth Headset icon
- Have a branch patch for 1.4, waiting for Gaia to reopen. (It might have already, will check after meeting)
- bug 1010104 - [Dialer][Call Screen] Baseline of the contact name when applying the fluid font size
- Reviewing for Germán. I think we're almost done.
- bug 1021478 - [1.4] Set outgoing calls "Always ask" with two sim card inside, use bluetooth headset to dial, there will be no network message
- Wei is asking for more help.
Rik
- 4-5 reviews
- Looking into Gaia integration tests being busted, backing out bug 1000428 did the trick.
- Landed Tamara's bug 1029721, worked with her on the unit tests
- Uplifted bug 1026081 for causing smoketest failures in bug
1039844
gtorodelvalle
- Administrative:
- SADLY I WON'T BE ABLE TO JOIN YOU IN July 18'S DAILY MEETING. SORRY! :(
- More sadly it seems I won't be able to have a patch for "bug 977056 - [Dialer] Visual discrepancies: Call ended view under conference call participants list" although I'll try it, on Monday :(
- bug 1018283 - [Follow-up 951665] Pending visual revision and adjustments of the VR call screen when in lockscreen:
- bug 1024506 - While call is "connecting", "Add other call", "Keypad" and "microphone" buttons should be disabled:
- Helping Paco to implement Anthony's comments to the pull request.
- Reimplementing it since starting from Paco's patch some issues arose :)
- Asked for revision to Anthony.
- Found that we currently do not disable the "Place new call" button when there are 2 ongoing calls (1 held and 1 connected). Asked Carrie for input on this.
- bug 1010104 - [Dialer][Call Screen] Baseline of the contact name when applying the fluid font size:
- Currently including Doug's comments in the patch.
- Implemented the new version with no getScenario() as suggested by Doug.
- Asked revision to Doug about the new version.
- bug 1035153 - [Dialer] Prototype sheet navigation layout:
- I checked Paco's implementation of the prototype and although we made really nice progress on it, many doubts came to my mind which I shared with Carrie in the bug. In my opinion it is much better to have all those issues clarified before throwing a line of code :p
thills
pacorampas
Day 9: July 17
| Meeting Minutes
|
- 14:31 drs ok I'm going to get us started since Rik is writing his update
- 14:31 drs hi etienne_s, gsvelto, gtorodelvalle, thills
- 14:31 gtorodelvalle Hi! ;)
- 14:31 thills hi drs
- 14:32 gtorodelvalle And davidg, I think :p
- 14:32 drs oh yeah, sorry
- 14:32 drs hi davidg
- 14:32 davidg hi :)
- 14:32 Rik hey sorry, was finishing my update
- 14:32 Rik so any administrative update?
- 14:32 drs on the admin side, the only new thing is that I'm working more on scoping out long-term projects, Rik has been doing this as well. the goal is to have enough things to assign to people when we start sprint planning again
- 14:32 drs that's all for me
- 14:33 drs (on admin side at least)
- 14:33 drs anyone else have any admin stuff?
- 14:33 drs ok, so as for my actual update:
- 14:33 gtorodelvalle Nope on my side
- 14:33 Rik let's also pause and celebrate the 0 blockers
- 14:33 drs ah, yes
- 14:33 gtorodelvalle :D
- 14:34 * drs wishes he knew the command to mute a channel
- 14:34 drs anyways, as for my actual update
- 14:34 Rik we all saw the email from drs so champagne! 4 days before the deadline
- 14:34 Rik now, drs
- 14:34 drs I only have one thing of note, the rest is on the etherpad
- 14:35 drs gtorodelvalle: we're getting pressure to land bug 1010104 so I'd like to do a live IRC review with you on the rest of it, if it's not ready already
- 14:35 firebot https://bugzil.la/1010104 — ASSIGNED, gtorodelvalle — [Dialer][Call Screen] Baseline of the contact name when applying the fluid font size
- 14:35 drs that's it for me
- 14:35 gtorodelvalle drs: Perfect! After this meeting if you wish
- 14:35 drs sure, sounds good
- 14:35 drs next is Rik
- 14:35 Rik drs: imho, this should not land on 2.0
- 14:35 drs Rik: I actually agree but I thought they had some weird reason for it to
- 14:36 drs you think we should dispute it?
- 14:36 gtorodelvalle I agree too, do not know if UX does not
- 14:36 drs it has no tracking flags, blocking status, approval, or anything
- 14:36 Rik with the blocker I fixed yesterday, I realised that we have a library that abstracts getting contacts info from mozContacts and Facebook
- 14:36 gtorodelvalle I think it is a look and feel thing
- 14:36 drs it seems really unimportant to me but we're landing js changes on a branch that already has stability problems
- 14:36 gtorodelvalle In fact, I have a way bigger one also trying to land in v2.0, I’ll share with you in a sec.
- 14:36 drs I'm really not in favor of it landing on 2.0 either but I assumed they had a good reason to
- 14:36 gtorodelvalle Yeap
- 14:37 Rik and I remember seeing some facebook code in call log and suggestions so I'll see if we can simplify our code now that this library works better
- 14:37 Rik next is davidg
- 14:37 drs Rik: can you make bugs for this?
- 14:37 drs and stick them on dialer-most-wanted
- 14:37 Rik drs: yes, I will
- 14:37 drs ok, thanks
- 14:38 davidg I just landed the ear problem bug, and looking at problems with audio channel
- 14:38 davidg I will probably fill a bug for gecko guys
- 14:38 davidg next :)
- 14:38 gtorodelvalle :)
- 14:38 Rik next is gsvelto
- 14:38 drs davidg: thanks for your update, but please refer to bug numbers when discussing bugs
- 14:38 Rik ( etienne_s I assume you don't have an update)
- 14:38 drs it makes it easier for us to know what you're talking about
- 14:39 davidg sorry! landed this 1039199
- 14:39 drs bug 1039199
- 14:39 firebot https://bugzil.la/1039199 — FIXED, david.garciaparedes — [Dialer] When you put the phone on your ear, tones are not played using telephony channel
- 14:39 Rik davidg: if you prefix by bug, firebot will fetch it
- 14:39 drs I don't think gsvelto is here
- 14:39 Rik maybe gsvelto is typing slowly
- 14:39 drs maybe we shuold move on
- 14:40 Rik or napping :0
- 14:40 Rik so gtorodelvalle
- 14:40 drs it's ok, he needs it
- 14:40 gtorodelvalle Vote for b)
- 14:40 gtorodelvalle OK, on my side the most noticeable thing is https://bugzilla.mozilla.org/show_bug.cgi?id=1039553
- 14:40 firebot Bug 1039553 — NEW — [Dialer][Call Screen] It's not possible to start a second call
- 14:40 gtorodelvalle Which would be great to have you Doug taking a look at
- 14:40 drs I strongly suspect that will get blocking status
- 14:40 drs yeah, I'll take it
- 14:40 gtorodelvalle Great!
- 14:41 gtorodelvalle Apart from that, we will land the baseline one after this meeting
- 14:41 gtorodelvalle And I have a very big one waiting to ask for approval: https://bugzilla.mozilla.org/show_bug.cgi?id=1018283
- 14:41 firebot Bug 1018283 — FIXED, gtorodelvalle — [Follow-up 951665] Pending visual revision and adjustments of the VR call screen when in lockscreen
- 14:41 gtorodelvalle But once again it is a look and feel one (and huge patch) so I do not know if it will end up landing in v2.0
- 14:42 gtorodelvalle Someone wants it :)
- 14:42 gtorodelvalle Next is thills :)
- 14:42 Rik so I think this one needs to land on 2.0 :)
- 14:42 thills I'm still working on gaia portion for bug 1029721. rik and gsvelto have been helping me with this (THANK YOU) I will have another version for review shortly.
- 14:42 firebot https://bugzil.la/1029721 — ASSIGNED, thills — CDMA call waiting call is not logged in call history
- 14:42 drs gtorodelvalle: doesn't look like you requested approval yet
- 14:42 gtorodelvalle drs: No, I was waiting to have all green before that, and Travis is pretty red https://travis-ci.org/mozilla-b2g/gaia/builds/30150713 but not due to issues related to my patch :(
- 14:43 thills that's all from my side
- 14:43 drs gtorodelvalle: ok, in this case if you want it to land on 2.0 we can't wait for the intermittents
- 14:43 drs I'll take a look
- 14:43 Rik I think it's a wrap
|
drs
- Admin:
- Next steps:
- bug 1037637 - [DSDS][Dialer] No text on "select SIM" prompt for outgoing calls
- Need to review this for Gandalf.
- bug 967440 - Remove some reflows on the keypad
- Next thing to work on, this is my last bug for this sprint.
- Scoping out more long-term work. In particular, I'm focused on being able to simulate situations such as emergency calls in Mulet.
- Done:
- Did some minor cleanups to the Etherpad-to-Wiki tool, such as fixing links, not including people who are commented out, properly parsing comments.
- bug 1035183 - Matching numbers screen results is not properly localized for 10+ matches
- Landed, this was the dialer team's final blocker!
- bug 1032725 - Facebook contact infos are not reflected in call screen
- Reviewed for Anthony and I landed this, this was the dialer team's _actual_ final blocker! (it popped up a few minutes before landing bug 1035183)
- bug 1030912 - [B2G][Dialer][Bluetooth] While in a call the Speaker icon is shown instead of the Bluetooth Headset icon
- Landed on 2.0, needs a branch patch for 1.4.
- bug 1010104 - [Dialer][Call Screen] Baseline of the contact name when applying the fluid font size
- Reviewed for Germán after he convinced me that my suggestions won't work (or at least aren't worth more time spent on them), r-
- bug 1021478 - [1.4] Set outgoing calls "Always ask" with two sim card inside, use bluetooth headset to dial, there will be no network message
- Need to help Wei figure out why he's getting a unit test failure.
Rik
- Still working with Tamara, face to face time is good
- Moved some bugs opened by Eric (QA) to dialer-most-wanted
- Fixed bug 1032725
- We may be able to remove some FB code from suggestion and call log
- Found bug 1039610 when working on 1032725
gtorodelvalle
- Administrative:
- Sadly it seems I won't be able to have a patch for "bug 977056 - [Dialer] Visual discrepancies: Call ended view under conference call participants list" although I'll try it, if not tomorrow on Monday ;)
- bug 1018283 - [Follow-up 951665] Pending visual revision and adjustments of the VR call screen when in lockscreen:
- Landed in master.
- Pull request for v2.0 ready: https://github.com/mozilla-b2g/gaia/pull/21804 Waiting for Travis and TBPL OK to ask for approval.
- After 23 hours neither Travis nor TBPL has started. Trying to contact someone to fix this.
- It takes so long to land patches that I am rebasing over and over again :(
- bug 1039553 - [Dialer][Call Screen] It's not possible to start a second call:
- I spent almost the whole morning trying to figure out the cause of this issue. At the end at least I found a way to get over it :p and now I am able to make second calls :)
- bug 1024506 - While call is "connecting", "Add other call", "Keypad" and "microphone" buttons should be disabled:
- Helping Paco to implement Anthony's comments to the pull request.
- Reimplementing it since starting from Paco's patch some issues arose :)
- Asked for revision to Anthony
- Found that we currently do not disable the "Place new call" button when there are 2 ongoing calls (1 held and 1 connected).
- bug 1010104 - [Dialer][Call Screen] Baseline of the contact name when applying the fluid font size:
- Currently including Doug's comments in the patch
pacorampas
- bug 1035153 - [Dialer] Prototype sheet navigation layout:
- I have some advances.
- Today I continue working on it
- bug 1024506 - While call is "connecting", "Add other call", "Keypad" and "microphone" buttons should be disabled.
- German is working on this bug now
- bug 1033937 - [Calllog] Tap on Withheld number in call log, item highlighted, but stay highlighted when finger released
thills
- bug 998147 -
- bug 1029721 - I am still working on this. Had some difficulties with the wake lock mechanism and associated tests and took help from Rik and Gabriele (Thank you). Will be putting another version for re-review shortly
Day 8: July 16
| Meeting Minutes
|
- [4:30pm] gtorodelvalle: Hi guys! 16:30 so let’s start our daily
- [4:30pm] mariaoteo: gtorodelvalle: you are right
- [4:30pm] gtorodelvalle: Administrative issues to comment?
- [4:31pm] drs: yes, I have a few
- [4:31pm] drs: I talked with lmandel about the release cycle
- [4:31pm] gtorodelvalle: Please, go ahead… I have one
- [4:31pm] drs: he explained a bunch of things to me, and I've summarized them on the etherpad
- [4:31pm] drs: I recommend you guys read them over, good things to know
- [4:31pm] mariaoteo: gtorodelvalle: black screen when you want to add a second call...
- [4:31pm] drs: second item for me is that I sent out a proposal for using styledocco with the dialer
- [4:32pm] drs: please take the time to read it and think about it
- [4:32pm] drs: I'd like to get some feedback and thoughts on it
- [4:32pm] Rik: thanks for starting this drs!
- [4:32pm] drs: that's it for me on the admin side
- [4:32pm] gtorodelvalle: I would only like to introduce you to David García Paredes (davidg) who will be helpig us in Dialer and related apps… He is currently working on a couple of tone related bugs
- [4:33pm] davidg: Hi guys nice to meet you
- [4:33pm] drs: oh, cool
- [4:33pm] drs: hi davidg
- [4:33pm] Rik: hi davidg
- [4:33pm] drs: are you the telefonica intern?
- [4:33pm] gtorodelvalle: Nope, the intern will join us on August, the 4th
- [4:33pm] drs: ah okay
- [4:33pm] drs: are you working full-time on the dialer?
- [4:33pm] davidg: I will be working on IoT bugs, and currently mostly are from coms
- [4:33pm] Rik: (Aug 4th, my birthday!)
- [4:33pm] drs: okay
- [4:34pm] Rik: can you remember us what IoT means?
- [4:34pm] drs: davidg: if you'd like to, you can write up a report on the etherpad on what you've done: https://etherpad.mozilla.org/fxos-dialer-scrum
- [4:34pm] drs: but if you're not working entirely on the dialer then it's probably not worth it
- [4:34pm] drs: you can give us updates on irc instead if you'd like
- [4:34pm] drs: anyways I'm sure gtorodelvalle has told you these things
- [4:34pm] drs: welcome
- [4:34pm] davidg: Certification?..I don't know the full acronym, but it is basically solving problems that carriers have identified
- [4:34pm] gtorodelvalle: He, he
- [4:35pm] davidg: thanks
- [4:35pm] gtorodelvalle: So the first round is on Rik … Any other administrative issue? If not, moving to drs
- [4:35pm] Rik: thanks
- [4:35pm] davidg: drs?
- [4:35pm] drs: so my only things of note are the styledocco proposal, and...
- [4:35pm] gtorodelvalle: Yeah, Doug’s nickname
- [4:36pm] drs: Rik: QA/relman is breathing down my neck on Bug 1035183 so a speedy review would be nice
- [4:36pm] drs: that's it for me
- [4:36pm] firebot: https://bugzil.la/1035183 — ASSIGNED, drs+bugzilla — Matching numbers screen results is not properly localized for 10+ matches
- [4:36pm] gtorodelvalle: Nice time to move to Rik
- [4:36pm] Rik: so I was reviewing drs' patch just before the meeting, will finish after
- [4:37pm] gtorodelvalle: davidg , do yo want to share anything with us? Any trouble?
- [4:37pm] drs: don't think Rik was done
- [4:37pm] davidg: yes indeed
- [4:37pm] gtorodelvalle: Ups
- [4:37pm] Rik: I don't have much code done these days, mostly reviews and discussions with francisco, sergi and thills
- [4:37pm] drs: what are you guys talking about? datastore?
- [4:38pm] Rik: performance regressions, frameworks, we talked a bit about datastore but mostly because I didn't know much about it
- [4:38pm] Rik: and just general sharing when we have a face to face
- [4:38pm] drs: can you write stuff down please?
- [4:38pm] drs: when you have meetings like this
- [4:38pm] drs: even just a quick summary afterwards
- [4:39pm] gtorodelvalle: (I think we should retake the “I’m done”, “Next” or something )
- [4:39pm] Rik: it was Contacts performance regressions
- [4:39pm] drs: ah okay, I thought you meant things within the dialer that they might know about
- [4:39pm] Rik: and datastore, I have nothing to write down, except what's already in MDN
- [4:40pm] Rik: but yes, I'm keeping in mind that decisions/ideas/areas to explore should be written down
- [4:40pm] drs: ok, thanks
- [4:40pm] Rik: and so I'm done
- [4:40pm] gtorodelvalle: He, he
- [4:40pm] gtorodelvalle: davidg ?
- [4:41pm] drs: (when everyone is done, I have 1 more thing I'd like to raise)
- [4:41pm] davidg: So, I have been working on playing a tone at the end a call, and I found a problem in the TonePlayer
- [4:41pm] davidg: in the callscreen app, I told etienne and he told me I should tell everybody just in case
- [4:42pm] gsvelto: davidg, yeah, the toneplayer is and endless source of pains
- [4:42pm] drs: what's the problem?
- [4:42pm] davidg: TonePlayer is supposed to be in 'telephony' channel while you are in a call and switch back to 'normal' when you are not
- [4:42pm] davidg: i don't know why it can't be always in 'telephony'
- [4:43pm] gsvelto: davidg, because telephony doesn't play anything if you're not on a call
- [4:43pm] davidg: It uses visiblitychange event to switch between normal and telephony
- [4:43pm] gsvelto: davidg, so if you want to play touchtones before being in a call you need to play them in the normal channel
- [4:43pm] gtorodelvalle: Shall we talk about this after the daily? SInce I guess it may take some time and it is an interesating topic
- [4:43pm] davidg: the problem is, that when you put the phone in your ear, it switchs off the screen
- [4:43pm] gsvelto: gtorodelvalle, yeah, sorry
- [4:43pm] drs: gtorodelvalle: agreed, thanks
- [4:44pm] davidg: ok the bug is 1039199
- [4:44pm] gtorodelvalle: Thanks!!! Next is etienne_s
- [4:44pm] davidg: is detailed there
- [4:44pm] drs: bug 1039199
- [4:44pm] firebot: https://bugzil.la/1039199 — NEW, david.garciaparedes — [Dialer] When you put the phone on your ear, tones are not played using telephony channel
- [4:44pm] drs: I think we can move on
- [4:44pm] davidg: sorry
- [4:44pm] drs: etienne_s is at the systems work week in berlin
- [4:44pm] gtorodelvalle: In the meantime, let’s go with gsvelto
- [4:44pm] WilfredM joined the chat room.
- [4:45pm] drs: and I doubt he's doing any dialer work besides reviews
- [4:45pm] gsvelto: so I've slept three hours, landed a workaround for Web Audio glitchiness in the tone player in bug 1022450
- [4:45pm] firebot: https://bugzil.la/1022450 — FIXED, gsvelto — [Flame] [V1.4][Dialer]The key press tone will distort when you tap the number key during the call.
- [4:46pm] gtorodelvalle: Next?
- [4:46pm] gsvelto: then I've done a review in bug 1029721 and I will be helping thills on that one
- [4:46pm] firebot: https://bugzil.la/1029721 — ASSIGNED, thills — CDMA call waiting call is not logged in call history
- [4:46pm] gsvelto: sorry, I've slept three hours and it takes me a minute to figure things out
- [4:46pm] gtorodelvalle: Sorry, I do not see any notification of you guys typing
- [4:46pm] gsvelto: this is all for me
- [4:46pm] gtorodelvalle: Thanks!
- [4:47pm] gtorodelvalle: On my side and to try to be quick, I am working on a couple of bugs (just took one from Paco) which made me realize that there’s some problem with adding a second call mariaoteo just confirmed… Trying to figure out the cause of the issue since this is blocking my testing of the patches.
- [4:47pm] gtorodelvalle: Next is thills
- [4:47pm] thills: I am trying to finish the blocker bug 1029721. I have the review from Hsin-yi, but I need to fix some feedback on the Gaia portion from gsvelto. So I will be focused on this since it's high priority.
- [4:47pm] scravag left the chat room. (Quit: Leaving.)
- [4:47pm] thills: that's it from my side
- [4:47pm] drs: thills: do you think you'll make it for FC day?
- [4:48pm] thills: drs: when is this?
- [4:48pm] Rik: tuesday
- [4:48pm] Rik: well, monday
- [4:48pm] thills: drs: I think so
- [4:48pm] drs: well, they want everything landed by friday
- [4:49pm] drs: but in reality the actual FC day is tuesday
- [4:49pm] drs: ok
- [4:49pm] gtorodelvalle: OK, guys, Thank you very much. I’ll update the wiki.
- [4:49pm] Rik: we land on monday morningish in europe
- [4:49pm] drs: wait
- [4:49pm] drs: I wanted to mention one more thing
- [4:49pm] gtorodelvalle: Right, last topic
- [4:49pm] drs: since there's so many of us, I don't think 10 minutes is a reasonable target anymore
- [4:49pm] drs: I think we should target 15 minutes for the meeting
- [4:49pm] gtorodelvalle: +1000
- [4:49pm] drs: so it doesn't feel rushed and pointless
- [4:50pm] drs: that's all
- [4:50pm] gtorodelvalle: Thanks!
- [4:50pm] gtorodelvalle: Rik , would you be able to host the meeting tomorrow?
- [4:50pm] Rik: (I'm not really looking at the time the whole meeting takes)
- [4:50pm] drs: Rik: I watch it like a hawk
- [4:50pm] Rik: (so I'm fine)
- [4:50pm] gtorodelvalle: And I feel it
- [4:50pm] Rik: gtorodelvalle: yes!
- [4:50pm] drs: I'm actually timing everyone's updates
- [4:50pm] gtorodelvalle: Thanks Rik
- [4:51pm] gtorodelvalle: I hear the tic tac from here :S
|
drs
- Admin:
- Talked with Germán and Maria to understand what work Maria is assigning to Germán.
- Talked with Lawrence and Wayne to clear up some things about the release cycle. Here's what Lawrence told me:
- 1.3T+ bugs still need approval for other branches
- 2.0 has a lot of stability problems.
- 1.4 branch is Dolphin-only. They've been having trouble managing this and some fixes getting uplifted are questionable.
- Next steps:
- bug 1035183 - Matching numbers screen results is not properly localized for 10+ matches
- Patch posted, waiting for review from Anthony. This is the dialer team's final blocker.
- bug 1037637 - [DSDS][Dialer] No text on "select SIM" prompt for outgoing calls
- Need to review this for Gandalf.
- bug 967440 - Remove some reflows on the keypad
- Next thing to work on, this is my last bug for this sprint.
- Done:
- bug 1030912 - [B2G][Dialer][Bluetooth] While in a call the Speaker icon is shown instead of the Bluetooth Headset icon
- Got 1.4 and 2.0 approval, have to land these (waiting for sheriffs).
- bug 1039131 - Prototype StyleDocco for generating stylesheet documentation
- Done, I also sent out a proposal that I would like everyone to read.
- bug 1010104 - [Dialer][Call Screen] Baseline of the contact name when applying the fluid font size
- I've been helping Germán do this another, cleaner, way.
- bug 1021478 - [1.4] Set outgoing calls "Always ask" with two sim card inside, use bluetooth headset to dial, there will be no network message
- Need to help Wei figure out why he's getting a unit test failure.
- bug 1039008 - URIs in iframes are relative to the iframe origin
- Reported as part of my work on StyleDocco. I need to make a reduced test case and come back to this.
- Other:
- bug 1032502 - 2.0+ The phone label of an incoming call on the lockscreen is not translated.
- They finally opted not to land this on 1.3T. I've landed it on 1.4.
gtorodelvalle
- bug 1018283 - [Follow-up 951665] Pending visual revision and adjustments of the VR call screen when in lockscreen:
- Landed in master.
- Pull request for v2.0 ready
- bug 1010104 - [Dialer][Call Screen] Baseline of the contact name when applying the fluid font size:
- Currently retaking it and checking Doug's comments.
- Working with Doug trying to find a simpler approach.
- bug 1024506 - While call is "connecting", "Add other call", "Keypad" and "microphone" buttons should be disabled:
- Helping Paco to implement Anthony's comments to the pull request.
- Reimplementing it since starting from Paco's patch some issues arose :)
- Other issues:
- Found an issue related to adding a second call which is blocking my tests for the patches I am working on. When clicking the "Place a new call" button, the ongoing call goes to the top but a black background is shown. Trying to figure out the cause of the problem. It reproduces in master.
thills
- bug 998147 -
- bug 1029721 - I have the review from Hsin-Yi, but got feedback from gsvelto that I need to fix on the Gaia portion to wrap this one up. Will be focusing on this.
Rik
pacorampas
etienne
gsvelto
Day 7: July 15
| Meeting Minutes
|
- 10:30 drs: ok, hi everyone
- 10:30 drs: looks like we have a bigger crowd today
- 10:31 drs: Rik, etienne_s, gsvelto, gtorodelvalle, thills
- 10:31 thills: hello
- 10:31 gtorodelvalle: \o/
- 10:31 drs: so on the admin, I've created a converter for etherpad-to-wiki format: http://people.mozilla.org/~dsherk/etherpad-wiki.html
- 10:31 drs: you can use this when you're hosting the standup
- 10:31 drs: it'll make saving to the wiki much faster
- 10:32 drs: does anyone have any other admin updates/
- 10:32 Rik: I think we should take a look at our sprint status
- 10:32 Rik: we're in the middle of it
- 10:32 drs: we have 1 blocker left
- 10:32 drs: https://wiki.mozilla.org/FirefoxOS/Comms/Dialer/Sprint/v2.0-S6
- 10:33 drs: we still have 7 open issues
- 10:33 drs: the prototype I don't really expect us to finish this week but if we can, that would be nice
- 10:33 drs: I think we're moving along ok, we'll probably have 2-3 open issues and 0 blockers by the end of the week
- 10:34 drs: I would consider that a success even if we don't close all issues
- 10:34 gtorodelvalle: Tomorrow we’ll give you an update on the prototype since I have not being able to chat with Paco today
- 10:34 drs: okay, thanks gtorodelvalle
- 10:34 drs: does anyone have anything to say about our status? gtorodelvalle, we were going to chat about that after the standup
- 10:34 Rik: drs: I'd love to only have the prototype one open
- 10:34 Rik: and it looks reasonable to think this will be the only one open
- 10:35 drs: Rik: sure, it's doable. I don't think it makes a big difference though to have 1 vs 2 if the other one is bug 967440 for example
- 10:35 firebot: https://bugzil.la/967440 — NEW, drs+bugzilla — Remove some reflows on the keypad
- 10:35 drs: anyways we should move on
- 10:35 drs: as for my update, I'm prioritizing bug 1035183
- 10:35 firebot: https://bugzil.la/1035183 — NEW, drs+bugzilla — Matching numbers screen results is not properly localized for 10+ matches
- 10:35 drs: as it's our last blocker
- 10:35 drs: I'm also working on a styledocco prototype for the dialer, but that will happen after this^
- 10:35 drs: that's it for me, Rik
- 10:36 wesley_huang has left IRC (Quit: wesley_huang)
- 10:36 Rik: so I've landed my blockers yesterday and today
- 10:36 Rik: I only have one bug assigned in this sprint so I'm looking at 2.1 and 2.2
- 10:37 Rik: I'll probably work with francisco on dialer/contacts long term projects
- 10:37 drs: we should chat about that afterwards
- 10:37 Rik: that's it
- 10:37 drs: ok, etienne_s I don't think is here
- 10:37 drs: so we'll go straight to gsvelto and etienne_s can tell us if he is
- 10:38 etienne_s: I'm doing gsvelto reviews :)
- 10:38 gsvelto: on my side I uplifted a patch I thought I had already uplifted (hah!)
- 10:38 gsvelto: bug 1019783
- 10:38 firebot: https://bugzil.la/1019783 — FIXED, gsvelto — Output from *#06# on FLAME DIALER used to return 2 IMEI
- 10:38 gsvelto: and I've prepared a workaround for more glitchy touch tones in bug 1022450
- 10:38 gsvelto: hurray for Web Audio
- 10:38 drs: nice
- 10:39 gtorodelvalle: :D
- 10:39 firebot: https://bugzil.la/1022450 — ASSIGNED, gsvelto — [Flame][V1.4][Dialer]The key press tone will distort when you tap the number key during the call.
- 10:39 gsvelto: and this is all, next is gtorodelvalle, right?
- 10:39 drs: yeah, or etienne_s
- 10:39 drs: etienne_s: if you want to say anything else
- 10:39 Rik: etienne said "I'm doing gsvelto reviews :)"
- 10:39 drs: yeah, I'm not sure if he wanted to say more
- 10:39 gtorodelvalle: Yeah, on my side I have not been able to make much progress on the main bug I should be working on (https://bugzilla.mozilla.org/show_bug.cgi?id=977056) since I have been asked to check and collaborate on 2.0 bugs (to have criteria to triage them, check possible solutions and so on). I am currently retaking the baseline one (comments provided by Doug) and afterwards I will retake the conference ending one. So
- 10:39 gtorodelvalle: hopefully everything will be back on track.
- 10:39 firebot: Bug 977056 — NEW, gtorodelvalle — [Dialer] Visual discrepancies: Call ended view under conference call participants list
- 10:39 drs: ok, thanks gtorodelvalle
- 10:39 drs: next is thills
- 10:40 gtorodelvalle: And asked Etienne for some input regarding tones too (we’ll contact Gabrielle in case additional issues arise :) )
- 10:40 thills: I am in the review cycle for both bug 998147 and bug 1029721. Both of these are two-part gaia/gecko fixes. Hsin-Yi tested 1029721 for me, but now she has an optimization so I need to have her retest this.
- 10:40 firebot: https://bugzil.la/998147 — ASSIGNED, thills — [Dialer] A Missed Call notification is given when chosing to hang up on an incoming call
- 10:40 firebot: https://bugzil.la/1029721 — ASSIGNED, thills — CDMA call waiting call is not logged in call history
- 10:40 drs: (sorry gtorodelvalle, thought you were done)
- 10:40 gtorodelvalle: No, no, go ahead thills :)
- 10:40 thills: ok, that's it for my side.
- 10:40 drs: ok, does anyone have anything they want to talk about?
- 10:41 drs: ok, thanks everyone, meeting ended
|
drs
- Admin:
- Next steps:
- Working on a proposal for using StyleDocco which I will send to the mailing list when ready.
- bug 1035183 - Matching numbers screen results is not properly localized for 10+ matches
- This is the 2nd last blocker, and my last blocker. Will prioritize this.
- bug 1037868 - Create gaia-sim-picker component
- Taking this for next sprint. kgrandon and I have been discussing next steps.
- Done:
- bug 1033937 - [Calllog] Tap on Withheld number in call log, item highlighted, but stay highlighted when finger released
- Did some research and created workaround for Paco, don't think we're going to land it though.
- bug 1010104 - [Dialer][Call Screen] Baseline of the contact name when applying the fluid font size
- Reviewed for Germán, review-, I proposed another way to do this.
- Now in discussion about how to do this.
- bug 1033196 - When dialing the user name part which containing j/g characters would be incomplete
- Reviewed for Anthony, checkin+
- bug 1021478 - [1.4] Set outgoing calls "Always ask" with two sim card inside, use bluetooth headset to dial, there will be no network message
- Other:
- bug 1032502 - 2.0+ The phone label of an incoming call on the lockscreen is not translated.
- Needs triaging to land on 1.3T. It got 1.4 approval but not 1.3T+ yet...
Rik
- Making sure we have all the 2.1 bugs in motion for next week
- I think we now have all of them. We will need to assign the new ones to Doug or I.
- Working closely with Tamara
- Still working with Tamara, face to face time is good
gtorodelvalle
- bug 1018283 - [Follow-up 951665] Pending visual revision and adjustments of the VR call screen when in lockscreen:
- Landed in master.
- I currently have a patch to ask for approval for v2.0. Mari Ángeles is dealing with triaging it and make it land in v2.0.
- bug 995938 - Device does not play an 'end tone' when the call is finished
- Collecting information about disconnected tone specs.
- Solution proposed based on playing the first tone of the busy tone.
- Helping David to solve the bug.
- bug 1038616 - [Dialer] Busy tone not playing:
- This bug popped up when working in the previous one.
- It reproduces in v2.0 so it is a candidate to be a blocker (according to the certification guys). It has just been nominated.
- bug 1010104 - [Dialer][Call Screen] Baseline of the contact name when applying the fluid font size:
- Currently retaking it and checking Doug's comments.
- Other issues:
- Today I spent some time with Beatriz (from Certification) checking the status of v2.0 regarding the Dialer / Call Screen / Emergency Call apps. It seems we are pretty good since there are no 2.0 unassigned blockers.
thills
- bug 998147 - Got reviews/feedback from Hsin-Yi and Anthony on this. We added a new unit test on this.
- bug 1029721 - Hsin-Yi tested out for me on CDMA device. It works. She had an optimization comment on the code which I can't verify locally so will need her to test it again.
pacorampas
Day 6: July 14
| Meeting Minutes
|
- 10:30 drs: hi all, hope you had a good weekend
- 10:30 drs: looks like we have a thinner crowd, probably because of the public holidays
- 10:30 drs: etienne_s: here? (you shouldn't be)
- 10:30 drs: and also gsvelto, thills
- 10:31 thills: Hello
- 10:31 gsvelto: hi everybody
- 10:31 drs: alright, looks like it's just the 3 of us
- 10:31 drs: this should be pretty short
- 10:31 drs: so there's no updates for anything admin related
- 10:32 gsvelto: right, the french are celebrating beheading the king
- 10:32 drs: as for my update, I'm working on a proposal to begin using styledocco within the dialer for writing more maintainable css
- 10:32 drs: I'll be sending it out to the mailing list when it's ready
- 10:32 drs: the rest of my updates are on the etherpad and don't really require your attention
- 10:32 drs: that's it for me, gsvelto
- 10:32 gsvelto: I'm about to land the patch for bug 1036386
- 10:32 firebot: https://bugzil.la/1036386 — ASSIGNED, gsvelto — When hitting network errors the SIM number is not displayed in MMI/USSD messages
- 10:33 gsvelto: which is follow up work for the MMI/USSD stuff I did last week
- 10:33 gsvelto: and then I'm preparing a workaround for bug 1022450
- 10:33 firebot: https://bugzil.la/1022450 — NEW — [Flame][V1.4][Dialer]The key press tone will distort when you tap the number key during the call.
- 10:33 gsvelto: there's already a workaround available for certain keypad scenarios and I want to extend it to cover all of them
- 10:33 gsvelto: still hoping to remove it as soon as the underlying gecko bug gets fixed
- 10:34 drs: that bug just doesn't stop biting us
- 10:34 gsvelto: BTW I've decided to tie up a few loose ends I had left in the dialer in the coming days
- 10:34 gsvelto: yeah
- 10:34 gsvelto: BTW none of these bugs are blockers but they're in my "it's about time" category
- 10:34 drs: loose ends?
- 10:34 drs: can you show me them?
- 10:34 drs: we have a new dialer-most-wanted bug which we're using as a metabug for stuff like this
- 10:35 gsvelto: sure, I'll add them there then
- 10:35 gsvelto: it's mostly cleanup & refactoring or follow-ups
- 10:35 drs: bug dialer-most-wanted (does this work?)
- 10:35 drs: guess not. bug 1036516
- 10:35 firebot: https://bugzil.la/1036516 — NEW — [meta][Dialer] Most Wanted
- 10:35 gsvelto: anyway this is all for me, thills
- 10:35 thills: ok, admin wise — I'm here in paris. I have patches for bug 1029721 and need to update it bc of lint error. I am going to see if Anshul can test as he/she has a cdma device and volunteered to test the patch…
- 10:35 firebot: https://bugzil.la/1029721 — ASSIGNED, thills — CDMA call waiting call is not logged in call history
- 10:36 drs: thills: is there anyone else there?
- 10:36 drs: it seems to be a recurring problem for us that we keep scheduling travel on public holidays
- 10:36 thills: and then I heard back from Hsin-yi on bug 998147 so I will prepare that patch based on her feedback that the original approach is ok
- 10:36 firebot: https://bugzil.la/998147 — ASSIGNED, thills — [Dialer] A Missed Call notification is given when chosing to hang up on an incoming call
- 10:36 thills: yes, Sergi and Francisco and David are here
- 10:36 drs: ok cool
- 10:37 thills: I'm trying to stop staring at teh ceilings :)
- 10:37 drs: yes. people complain that they don't want to work there because it doesn't feel like an office
- 10:37 drs: anyways, I think that's it, that was nice and short. thanks everyone
- 10:37 thills: thanks drs
- 10:37 drs: enjoy paris, thills
- 10:38 thills: thank you drs. I am sure I will
- 10:38 gsvelto: btw just one last thing
- 10:38 gsvelto: I've been browsing the dialer component and from what I can see it's got far more bugs filed than other components such as SMS
- 10:38 drs: yes, anthony and I have been talking about that
- 10:38 gsvelto: I think it's mostly due to duplicates and stuff that's been fixed but never closed
- 10:38 gsvelto: we should take some time every week to do a bit of cleanup
- 10:39 gsvelto: I've closed 3 dupes just last week
- 10:39 drs: would you raise this to the mailing list?
- 10:39 drs: (or I can)
- 10:40 gsvelto: yes, go ahead
|
drs
- Admin:
- Next steps:
- Working on a proposal for using StyleDocco which I will send to the mailing list when ready.
- Need to bug UX for specs for bug 877971.
- bug 1035183 - Matching numbers screen results is not properly localized for 10+ matches
- This is the 2nd last blocker, and my last blocker. Will prioritize this.
- bug 1037868 - Create gaia-sim-picker component
- Taking this for next sprint. kgrandon and I have been discussing next steps.
- Done:
- bug 1029581 - [Dialer] Contact name is not shown in the call log after having two contacts with same number and the first one is removed
- Reviewed for Anthony, checkin+
- bug 1010104 - [Dialer][Call Screen] Baseline of the contact name when applying the fluid font size
- Reviewed for Germán, review-, I proposed another way to do this.
- bug 1030912 - [B2G][Dialer][Bluetooth] While in a call the Speaker icon is shown instead of the Bluetooth Headset icon
- Reviewed for me by Ian Liu, checkin+
- bug 1038002 - Holding your finger down and then trying to pan gets stuck until the next touch
- bug 1033196 - When dialing the user name part which containing j/g characters would be incomplete
- Reviewed for Anthony, review+
- bug 1033943 - [B2G] [Dialer] cannot make a call right after unlocking PIN code upon Dialer app
- Resolved invalid after some investigation.
- Other:
- bug 1032502 - 2.0+ The phone label of an incoming call on the lockscreen is not translated.
- Needs triaging to land on 1.3T. It got 1.4 approval but not 1.3T+ yet...
Rik
gtorodelvalle
- SADLY I WON'T BE ABLE TO JOIN YOU GUYS July 14 :(
- bug 1018283 - [Follow-up 951665] Pending visual revision and adjustments of the VR call screen when in lockscreen:
- Thanks to Doug for landing bug 1018283 - [Follow-up 951665] Pending visual revision and adjustments of the VR call screen when in lockscreen \o/
- Analysing the possibility to ask for approval to 2.0 due to the complexity of the patch. Mental note: Do not refactor in feature bugs :p
- Currently I have a working 2.0 version of the patch I will share with Mari Ángeles regarding the way to proceed.
- bug 995938 - Device does not play an 'end tone' when the call is finished
- Collecting information about disconnected tone specs.
- Helping David solving the bug.
- bug 1033937 - [Calllog] Tap on Withheld number in call log, item highlighted, but stay highlighted when finger released
- Discussing with Paco ways to proceed in this bug.
- Other issues:
- I also helped Alberto Villena with a failing integration dialer test (PIN changing via MMI).
- I will meet tomorrow with Paco since we have had a lot of distraction these last days regarding the bugs assigned to us in this sprint to decide the way to proceed (elevating an alert about the risk not to accomplish them if appropriate)
- drs: Can we talk about this? Would like to know what you mean. In general, the more information you give us, the better.
- Absolutely. I have to leave now (already running late) but we can chat tomorrow. I will have a more quiet afternoon ;)
- drs: Okay cool, please keep this here so we remember.
- Sure ;)
thills
- bug 998147 - Heard back from Hsin-Yi on this one and I will prepare the original patch based on her feedback.
- bug 1029721 - Prepared the two part patch. Need to fix a lint error (from Travis failure) and then will see if someone can help to test it on actual CDMA device. Anshul has volunteered to help test it.
pacorampas
Day 5: July 11
| Meeting Minutes
|
- 10:31 thills: yes, let's get started
- 10:31 drs: ok, everyone but etienne_s is here, and he'll be back in a moment
- 10:31 thills: drs: did you want to start?
- 10:31 drs: sure
- 10:31 drs: so some admin stuff
- 10:31 drs: first of all, vicky (our VD) has left and we have a new member, carol huang, who is joining us and taking her place
- 10:32 drs: I've created a fxos-dialer mailing list as well and all of you are subscribed to it
- 10:32 drs: please use it for anything you think requires discussion with the whole team. we'll begin using it more once we start scoping out the long-term projects
- 10:32 drs: thills and I are both having wasabi devices sent to us so we'll be able to work on CDMA finally
- 10:32 drs: that's it for admin, now for my actual update
- 10:33 drs: I'm reviewing bug 1029581 for Rik, that's my top priority right now
- 10:33 etienne_s: here
- 10:33 drs: I also need a reply from etienne_s on bug 1030912
- 10:33 firebot: https://bugzil.la/1029581 — ASSIGNED, anthony — [Dialer] Contact name is not shown in the call log after having two contacts with same number and th
- 10:33 firebot: https://bugzil.la/1030912 — ASSIGNED, drs+bugzilla — [B2G][Dialer][Bluetooth] While in a call the Speaker icon is shown instead of the Bluetooth Headset
- 10:33 drs: that's it for me
- 10:33 thills: thanks drs. Next is Rik
- 10:34 Rik: so I have one 1.4+ blocker to review/finish (because it's from a partner)
- 10:35 Rik: in admin stuff, I'll be celebrating the french revolution next monday
- 10:35 Rik: and we'll have thills, sergi, francisco and wilfred in Paris for the whole week
- 10:35 Rik: that's it for me
- 10:35 thills: thanks Rik. Next is etienne_s
- 10:36 etienne_s: quick admin, I'll be at the system work week in berlin next week so I probably won't attend this meeting, but available via needinfo/ping as needed
- 10:36 etienne_s: and I'll check Doug's patch right away
- 10:36 drs: thanks etienne_s
- 10:37 Rik: those fancy system people who still get to do work weeks!
- 10:37 etienne_s: Rik: planned long ago on the cheap (co working space/ibis hotel) :)
- 10:38 Rik: next is?
- 10:38 thills: gsvelto
- 10:38 gsvelto: for my part I've finished landing the remaining USSD/MMI/IMEI fixes on all branches
- 10:38 Rik: (he may have fallen asleep waiting for some coffee :D)
- 10:38 gsvelto: And I've prepared a patch for bug 1036386
- 10:38 firebot: https://bugzil.la/1036386 — ASSIGNED, gsvelto — When hitting network errors the SIM number is not displayed in MMI/USSD messages
- 10:38 gsvelto: That's it for me
- 10:39 thills: thanks gsvelto. Next is me
- 10:39 thills: so, got a feedback from Hsin-Yi on the gecko portion of the cdma bug
- 10:39 thills: and I'm working on the gaia portion today.
- 10:39 thills: I might need few questions to someone knowledgable on call log
- 10:40 thills: etienne_s is that you?
- 10:40 drs: yeah, or Rik
- 10:40 thills: ok, thanks.
- 10:40 Rik: I've been deep in call log lately :)
- 10:40 drs: one last note I'd like to raise
- 10:40 etienne_s: thills: me if it's about saving, Rik if it's about displaying :) (somewhat arbitrary but it should work)
- 10:40 thills: ok and then admin side. Will be in Paris office on Monday
- 10:41 drs: is jealous
- 10:41 drs: enjoy it, great office
- 10:41 thills: I know… really looking forward to meeting everyone
- 10:41 drs: and plus it has etienne_s and Rik
- 10:41 Rik: well, not etienne_s next week
- 10:41 drs: ah, right
- 10:42 drs: okay, last thing I wanted to mention:
- 10:42 Rik: thills: can you join #fxos-comms to discuss next week a bit?
- 10:42 drs: when referring to bugs, please put "bug xxx" in your message so we know what you're referring to
- 10:42 drs: people have been getting a bit lazy about this during the standups and it makes it harder to know what you're talking about
- 10:42 drs: so you're less likely to get help/comments on it
- 10:43 drs: if you don't really need feedback then it doesn't really matter
- 10:43 drs: so it's no big deal, just a note
- 10:43 drs: anyways that's all I wanted to say, I think you can close it up thills
- 10:43 thills: ok, thanks everyone
|
drs
- Admin:
- We have a new team member, Carol Huang, our visual designer to replace Vicky.
- We now have a fxos-dialer@mozilla.org mailing list. I sent out a welcome email to everyone, and added Carol.
- Tamara and I will both have working Wasabi devices sent to us soon! We'll be able to test CDMA properly.
- bug 1018283 - [Follow-up 951665] Pending visual revision and adjustments of the VR call screen when in lockscreen
- Next steps:
- Need to bug UX for specs for bug 877971.
- bug 1029581 - [Dialer] Contact name is not shown in the call log after having two contacts with same number and the first one is removed
- Currently reviewing this for Anthony. Lots of unfamiliar code so this'll be slow, but good for learning.
- bug 1010104 - [Dialer][Call Screen] Baseline of the contact name when applying the fluid font size
- Need to review this for Germán. Intuitively this seems unnecessary but I need to spend more time on it.
- bug 1030912 - [B2G][Dialer][Bluetooth] While in a call the Speaker icon is shown instead of the Bluetooth Headset icon
- I put up a patch and Etienne reviewed it, waiting for his reply to mine.
- Done:
- bug 1037066 - [Dialer] Keypad background color changes are delayed
- Filed and put up a WIP which fixes it but isn't landable. This is an APZC issue. I'll come back to it later.
- Other:
- bug 1032502 - 2.0+ The phone label of an incoming call on the lockscreen is not translated.
- Needs triaging to land on 1.3T. It got 1.4 approval yesterday but not 1.3T+ yet...
Rik
- Blockers:
- bug 1029581 : Finally in review. Even though it took a bit of time to write the tests as expected, it took me longer than expected
- Monday is a holiday in France
- Tamara, Francisco, Wilfred and Sergi will be in Paris next week.
gtorodelvalle
- On PTO today only
- bug 1018283 - [Follow-up 951665] Pending visual revision and adjustments of the VR call screen when in lockscreen
pacorampas
thills
- bug 998147 - No updates on this one today.
- bug 1029721 - Put a WIP Gecko patch for Hsin-Yi to look at. She is ok with the change to fix this. I am now working on the Gaia piece for this and hope to have the complete patch soon.
Day 4: July 10
| Meeting Minutes
|
- [14:31] <Rik> ok let's start
- [14:31] <Rik> drs: etienne_s: gsvelto: thills
- [14:31] <etienne_s> o/
- [14:31] <thills> here
- [14:31] <Rik> let's start with etienne_s since drs didn't answer yet
- [14:31] <drs> hello
- [14:31] <gsvelto> pong
- [14:31] <drs> sorry, bouncer disconnected me for some reason
- [14:31] <etienne_s> nothing on my side, apart from the audio competing stuff which is landing today (we had a platform issue yesterday)
- [14:32] <Rik> ok thanks
- [14:32] <Rik> gsvelto: next
- [14:32] <Rik> (drs, we'll come back to you at the end)
- [14:32] <gsvelto> so today I landed bug 1019783
- [14:32] <firebot> https://bugzil.la/1019783 — FIXED, gsvelto — Output from *#06# on FLAME DIALER used to return 2 IMEI
- [14:32] <gsvelto> and I've just uplifted it to v1.4 too
- [14:32] <gsvelto> I have to ask for v2.0 approval and as I had forgot previously I really have to shoot an e-mail at dev-gaia on the topic
- [14:33] <gsvelto> it's totally silly that something that's 1.4+ needs explicit approval to land on 2.0
- [14:33] <drs> gsvelto: that's not true actually
- [14:33] <drs> I talked with lawrence about this
- [14:33] <drs> he cleared some stuff up
- [14:33] <drs> a 1.3T+ bug needs approval for any other branch
- [14:33] <drs> but any other 1/2.X+ bug doesn't need approval for any later branches
- [14:33] <drs> for example, a 1.4+ bug can land on 2.0+
- [14:33] <gsvelto> drs, ah, ok, fine
- [14:34] <gsvelto> drs, that'll save me some time
- [14:34] <Rik> let's still have this discussion in dev.gaia so that every gaia dev knows about this
- [14:34] <drs> he said a lot of people have been landing 1.3T+ bugs on other branches, like 1.4, but they shouldn't be doing that
- [14:34] <Rik> let's have this discussion after the meeting
- [14:34] <gsvelto> anyway I've also got a patch for bug 1036386 which is follow up work
- [14:34] <Rik> gsvelto: anything else?
- [14:34] <firebot> https://bugzil.la/1036386 — ASSIGNED, gsvelto — When hitting network errors the SIM number is not displayed in MMI/USSD messages
- [14:34] <gsvelto> and bug 1008737 which is not in the dialer but still has to do with IMEIs :-p
- [14:34] <firebot> https://bugzil.la/1008737 — ASSIGNED, gsvelto — [DSDS] [Flame] Only first IMEI is exposed in Settings -> About
- [14:34] <gsvelto> and I'm done, next is gtorodelvalle
- [14:35] <gtorodelvalle> Hi guys! Not much to update on my side… I spent quite some time onboarding David García Paredes (I will introduce him to you soon :) ) and my life these days is all about https://bugzilla.mozilla.org/show_bug.cgi?id=1018283 Currently rebasing again and fixing the failing tests… It is a matter of time I manage to land this one ;)
- [14:35] <firebot> Bug 1018283 — REOPENED, gtorodelvalle — [Follow-up 951665] Pending visual revision and adjustments of the VR call screen when in lockscreen
- [14:35] <gtorodelvalle> Paco is working on the prototype :)
- [14:35] <drs> gtorodelvalle: which tests are failing?
- [14:36] <drs> gtorodelvalle: is it still intermittents or from other components
- [14:36] <drs> or are they tests that your patch is causing to fail?
- [14:36] <gtorodelvalle> Oh man! Right now some bootstrap one but I recall that it also happened in the past and could be a mater one
- [14:36] <gtorodelvalle> I doubt of myself right now :p
- [14:36] <gtorodelvalle> I am tracking it to clarify it, again
- [14:36] <drs> that sounds like an intermittent, try re-running it
- [14:36] <gtorodelvalle> Yeah, on it
- [14:36] <drs> btw, it's nice that you're looking into all these intermittents, but you can still land your patch if you're not causing any new failures
- [14:37] <gtorodelvalle> I’ll contact you if this goes on
- [14:37] <drs> ok, sure
- [14:37] <gtorodelvalle> ;)
- [14:37] <Rik> next is me I guess
- [14:37] <gtorodelvalle> So next would be Rik
- [14:37] <gtorodelvalle> yeap
- [14:37] <Rik> on the blocker side, I'm writing tests for the one I'm working on
- [14:38] <Rik> also drs opened https://bugzilla.mozilla.org/show_bug.cgi?id=dialer-most-wanted yesterday
- [14:38] <drs> yeah, Rik and I will be gradually filling that with things
- [14:38] <drs> and we encourage you guys to do so too
- [14:38] <Rik> we're going to use this to track things that we want to work on but are not blockers, heavy features, etc
- [14:39] <Rik> so that during sprint planning, we can take some items from this meta bug
- [14:39] <Rik> next is thills
- [14:39] <drs> the goal is to always have something to work on
- [14:39] <thills> so, for both bug 998147 and bug 1029721 I am planning to see if I can get some time on IRC from Hsin-Yi tonight when she comes online. The CDMA one, I'm pretty much reading code. I need a session with her.
- [14:39] <firebot> https://bugzil.la/998147 — ASSIGNED, thills — [Dialer] A Missed Call notification is given when chosing to hang up on an incoming call
- [14:39] <firebot> https://bugzil.la/1029721 — ASSIGNED, thills — CDMA call waiting call is not logged in call history
- [14:40] <Rik> thills: for the CDMA one, maybe gsvelto can help you a bit?
- [14:40] <gsvelto> thills, I feel your pain, I've done all the CDMA stuff by reading the code (and sometimes the specs)
- [14:40] <Rik> (I don't know the context)
- [14:40] <gsvelto> Rik, the context is that we don't have a way to test our code, neither a device nor the emulator
- [14:40] <gsvelto> Rik, so we develop blindly
- [14:40] <drs> oh, so an update on that:
- [14:41] <thills> gsvelto I might ping you on this… to help interpret her comment in the bug
- [14:41] <drs> scravag contacted wesley who has found a wasabi device
- [14:41] <gsvelto> thills, sure
- [14:41] <drs> but we could really use a second for both thills and I
- [14:41] <gsvelto> drs, and maybe one for me too ;)
- [14:41] <drs> gsvelto: oh, I thought you don't have any CDMA networks nearby?
- [14:41] <Rik> gsvelto: (I meant which topic thills needs to talk about with hsin-yi)
- [14:42] <gsvelto> drs, right, I don't :(
- [14:42] <thills> rik: the cdma one.
- [14:42] <drs> yeah, we still have CDMA in NA
- [14:42] <Rik> I hear wesley will ship a gsvelto to North America :)
- [14:42] <Rik> thills: anything else?
- [14:42] <thills> rik: also, the one you commented on, bug 998147, I wnat to get her feedback on that. Becase i don't know how to proceed.
- [14:42] <gsvelto> drs, save that wasabi for someone else :'(
- [14:42] <drs> gsvelto: I think thills could use it the most
- [14:42] <drs> followed by me
- [14:43] <thills> that's it for me
- [14:43] <drs> ok
- [14:43] <drs> administrative: the fxos-dialer mailing list hasn't been created yet by IT but will be soon, I'll add everyone to it when it is
- [14:43] <Rik> ok next is drs then
- [14:43] <drs> I have to review Bug 1010104 for gtorodelvalle, which I'll do today
- [14:43] <firebot> https://bugzil.la/1010104 — NEW, gtorodelvalle — [Dialer][Call Screen] Baseline of the contact name when applying the fluid font size
- [14:43] <drs> that's it for me
- [14:43] <drs> (other than the etherpad notes)
- [14:44] <Rik> administrative
- [14:44] <Rik> we have two blockers without an assignee
- [14:44] <Rik> https://wiki.mozilla.org/FirefoxOS/Comms/Dialer/Sprint/v2.0-S6#Blockers_Without_an_Assignee
- [14:44] <drs> ah, good catch
- [14:44] <Rik> I've already commented on the two
- [14:45] <Rik> the first one already has a patch but I don't want to take it into 1.4
- [14:45] <Rik> the second one will probably need someone to work on it once we know what to do
- [14:45] <Rik> any taker?
- [14:45] <Rik> that would be https://bugzilla.mozilla.org/show_bug.cgi?id=1035183
- [14:45] <drs> I can take it
- [14:46] <firebot> Bug 1035183 — NEW — Matching numbers screen results is not properly localized for 10+ matches
- [14:46] <Rik> good then
- [14:46] <Rik> meeting adjourned! :)
- [14:46] <gsvelto> Rik, thanks, see you tomorrow!
- [14:46] <Rik> thills: do you want to run the meeting tomorrow? :)
- [14:46] <thills> rik: sure, I can do that
- [14:47] <gtorodelvalle> Ups, that reminds me that I will be on PTO tomorrow… :)
- [14:47] <gtorodelvalle> I’ll update my user in Bugzilla EOB
- [14:48] <drs> gtorodelvalle: can you write any notes on the etherpad before you go?
- [14:49] <gtorodelvalle> drs: Yeah, I’ll update the status of https://bugzilla.mozilla.org/show_bug.cgi?id=1018283 ;)
- [14:49] <firebot> Bug 1018283 — REOPENED, gtorodelvalle — [Follow-up 951665] Pending visual revision and adjustments of the VR call screen when in lockscreen
- [14:50] <Rik> drs: btw, our sprints go from tuesday to monday
- [14:51] <Rik> we decided this because it aligns with gecko branches
- [14:51] <drs> Rik: okay, thanks
|
drs
- bug 1026692 and bug 877971.
- Submitted request for fxos-dialer@mozilla.org mailing list.
- bug dialer-most-wanted
- bug 1030912 - [B2G][Dialer][Bluetooth] While in a call the Speaker icon is shown instead of the Bluetooth Headset icon
- I have a patch, just cleaning it up.
- bug 1032502 - 2.0+ The phone label of an incoming call on the lockscreen is not translated.
- Needs triaging to land on 1.3T and 1.4. (still, but at least I bugged Lawrence yesterday)
- bug 1010104 - [Dialer][Call Screen] Baseline of the contact name when applying the fluid font size
- Need to review this for Germán.
Rik
- Blockers:
- bug 1030550 : the Gecko fix is enough! We'll verify when it lands
- bug 1029581 : I'm writing the tests but they are the first for that area of the code so there's some setup to do
- bug dialer-most-wanted
- ICE meeting with Carrie, Francisco and Wilfred
- Finished all my reviews
gtorodelvalle
- bug 1018283 - [Follow-up 951665] Pending visual revision and adjustments of the VR call screen when in lockscreen:
- New rebasing on the fly ;)
- bug 1010104 - [Dialer][Call Screen] Baseline of the contact name when applying the fluid font size:
- Vertical homescreen tests failing in Travis.
- Just asked Anthony for review and rebased the patch to see if the Vertical Homescreen is solved.
- Revision moved to Doug.
pacorampas
- bug 1035153 - [Dialer] Prototype sheet navigation layout:
- Paco just started working on it.
- I (gtorodelvalle)'ll ask Paco to fill this Etherpad from tomorrow on.
- bug 1024506 - While call is "connecting", "Add other call", "Keypad" and "microphone" buttons should be disabled.
- I have worked on changes of my previus patch that Anthony said to me.
- Now, I should work on tests of it, but I think first I will asked for review.
- bug 1033937 - [Calllog] Tap on Withheld number in call log, item highlighted, but stay highlighted when finger released
- Here, I have a little issue to comment. Tomorrow I ask feedback on bugzilla.
- bug 1033970 - Line not complete highlighted when tapping on a participant in a multiparty call
- This bug is ready for landing but I first I need Anthony's feedback. He has a NI on bugzilla.
thills
- bug 998147 - Hsin-yi is looking for a different design to not overuse the telephony-call-ended event. I have an NI on this. My plan is to try and catch her online tonight to discuss how we can use the events vs. the system message.
- bug 1029721 - Struggling with this one a bit without a device to try anything on. I'm basically reading the code and trying to understand the flow of this one. Again, will try and meet with Hsin-Yi tonight when she comes online.
Day 3: July 9
| Meeting Minutes
|
|
[4:31pm] gtorodelvalle: OK guys, it is 16:30 on my clock so let’s start with the daily meeting. I guess everyone in on board
[4:31pm] thills: hello
[4:31pm] drs: (I usually ping etienne_s since he has a bouncer)
[4:31pm] etienne_s: here
[4:31pm] drs: administrative items: I filed a request to create a fxos-dialer@mozilla.org mailing list, so we'll have that soon
[4:31pm] drs: that's it for admin
[4:32pm] gtorodelvalle: Regarding administrative issues, let me just mention that in the coming days a new scholarship holder will be joining us. I was today filing some stuff about it
[4:32pm] gtorodelvalle: Just a quick “administrative” question for drs
[4:32pm] drs: scholarship holder? is that an intern?
[4:32pm] gtorodelvalle: Yeah, didn’t know how to express it ;9 Thanks
[4:32pm] drs: heh, ok
[4:32pm] gtorodelvalle: Any other administrative issues?
[4:32pm] drs: oh, what was your question?
[4:33pm] drs: or do you want to chat after?
[4:33pm] gtorodelvalle: yeah, probably better
[4:33pm] drs: okay, sure
[4:33pm] gtorodelvalle: It is about the minutes
[4:33pm] drs: yeah let's chat after
[4:33pm] gtorodelvalle: So moving to thills (in descending order, right?)
[4:33pm] thills: ok
[4:34pm] drs: descending would start with me and go to thills last but sure, let's do that instead
[4:34pm] thills: Spent all my time yesterday on Bug 998147. Gave a WIP patch last night for Hsin-Yi to review. She has an alternate approach that I have some questions on. So, I have a NI on that. I will spend some time trying to see if that is possible and then start working on Bug 1029721. I think I have a much better idea how to fix that after working on 998147.
[4:34pm] firebot: https://bugzil.la/998147 — ASSIGNED, thills — [Dialer] A Missed Call notification is given when chosing to hang up on an incoming call
[4:34pm] firebot: https://bugzil.la/1029721 — ASSIGNED, thills — CDMA call waiting call is not logged in call history
[4:34pm] gtorodelvalle: That’s ascending to me
[4:34pm] drs: nope, your way is ascending, but don't worry about it
[4:34pm] gtorodelvalle: Maybe we should say “next” or something?
[4:34pm] Rik: thills: I've left a comment for hsin-yi's approach
[4:35pm] thills: rik: yes, I saw that. I had the same question, but you expressed it better
[4:35pm] gtorodelvalle: Once you have finished, thills, please say “OVER”, “next” or something
[4:36pm] thills: ok, next
[4:36pm] gtorodelvalle: Thanks!
[4:36pm] gtorodelvalle: So let’s get back to descending, drs ?
[4:36pm] drs: heh, ok
[4:36pm] drs: my only item for others consideration is bug 1032502 which is still blocked waiting for triaging so I can land it on 1.3T and 1.4
[4:36pm] firebot: https://bugzil.la/1032502 — FIXED, drs+bugzilla — [B2G][2.0][Lockscreen] The phone label of an incoming call on the lockscreen is not translated.
[4:36pm] drs: next is etienne_s
[4:36pm] gtorodelvalle:
[4:37pm] Rik: you meant I can't land it, right ?
[4:37pm] drs: well, I can land it, it just hasn't been given permission
[4:37pm] drs: it's 1.3T?. I landed it on 2.0 because it was 2.0+ before I requested 1.3T?
[4:38pm] drs: anyways, don't worry about it, I'll start bugging more people the longer it sits waiting
[4:38pm] gtorodelvalle: etienne_s , anything to share with us?
[4:38pm] drs: I think etienne_s is afk, let's go to gsvelto
[4:38pm] etienne_s: not much, the audio competing stuff should land today it was well tested but if we see weird regression we might want to check here first
[4:38pm] drs: nevermind
[4:38pm] gtorodelvalle: Thanks! gsvelto ?
[4:38pm] • etienne_s looking for the bug number
[4:39pm] gsvelto: I've completed a fix for bug 1019783
[4:39pm] firebot: https://bugzil.la/1019783 — REOPENED, gsvelto — Output from *#06# on FLAME DIALER used to return 2 IMEI
[4:39pm] gsvelto: Now it's waiting for review, I think it's my last 1.4+ blocker
[4:39pm] gtorodelvalle: \o/
[4:39pm] gsvelto: I've also filed a follow up (with a patch ready), bug 1036386
[4:39pm] firebot: https://bugzil.la/1036386 — ASSIGNED, gsvelto — When hitting network errors the SIM number is not displayed in MMI/USSD messages
[4:39pm] gsvelto: Plus plenty of uplifts, you know every patch we make at this time lands on 3/4 branches
[4:40pm] gsvelto: It's outside of the dialer but it covers the same stuff so I'm also fixing bug 1008737
[4:40pm] firebot: https://bugzil.la/1008737 — NEW — [DSDS] [Flame] Only first IMEI is exposed in Settings -> About
[4:40pm] gsvelto: So I guess the next is gtorodelvalle
[4:40pm] gtorodelvalle: On my side, the most noticeable issue are a couple of bugs I found in master regarding tests failing (which made me lost quite some time) I just reverted one of the involved commits
[4:40pm] gtorodelvalle: https://bugzilla.mozilla.org/show_bug.cgi?id=1036378
[4:40pm] firebot: Bug 1036378 — NEW — [System] [Test] app_install_manager_test.js passing locally but with errors on the console
[4:40pm] gtorodelvalle: https://bugzilla.mozilla.org/show_bug.cgi?id=1023197
[4:40pm] firebot: Bug 1023197 — NEW, rlu — [Mulet] keyboard unit test render_test.js fails because it rely on specific Linux fontconfig
[4:40pm] drs: (that was really fast)
[4:40pm] gtorodelvalle: Just in case you see errors on your pull requests
[4:40pm] gtorodelvalle:
[4:40pm] gtorodelvalle: Rik ?
[4:41pm] gtorodelvalle: (almost out of time )
[4:41pm] drs: it's ok, we have yet to beat 11 minutes
[4:41pm] gtorodelvalle:
[4:41pm] Rik: so QA took a look at bug 1029581 so I'll provide a full patch now
[4:41pm] firebot: https://bugzil.la/1029581 — ASSIGNED, anthony — [Dialer] Contact name is not shown in the call log after having two contacts with same number and th
[4:41pm] Rik: I'm still investigating bug 1030550 with Henry
[4:41pm] firebot: https://bugzil.la/1030550 — NEW, hchang — [Dialer][Bluetooth] Callscreen app sometimes calls BT command "CHLD=3" twice when it only receive on
[4:42pm] drs: before we close up, I just wanted to mention one thing
[4:42pm] Rik: I had a meeting about Call log durations with Carrie, Francisco and Wilfred
[4:42pm] drs: (will wait for Rik to be done)
[4:42pm] Rik: and last thing, I was thinking we could use the relnote keyword to track things we want to demo/blog post, etc
[4:42pm] drs: yeah, I like that idea
[4:43pm] drs: is that it Rik?
[4:43pm] Rik: yes
[4:43pm] drs: ok, so my final note:
[4:43pm] Rik: (that's why I said last thing )
[4:44pm] drs: I notice this standup that there's a trend of mentioning everything you're doing because we don't have the etherpad anymore. in general it's best to only mention things that would matter to other people or that you want discussion on
[4:44pm] drs: so I specifically excluded the bugs I'm working on right now because I don't need feedback from others, I only mentioned things that matter to the rest of the team
[4:44pm] gtorodelvalle: Don’t we have the Etherpad anymore?
[4:44pm] drs: we don't use it anymore
[4:44pm] gtorodelvalle: OK, but should we?
[4:44pm] drs: we agreed to use bug statuses instead
[4:44pm] gtorodelvalle: OK
[4:44pm] drs: there was a consensus that it was wasting people's time
[4:45pm] drs: but if this trend continues, it might be worth it to go back to the etherpad
[4:45pm] drs: anyways, that's all I wanted to say
[4:45pm] drs: gtorodelvalle: I think you can close off the meeting
[4:45pm] gtorodelvalle: We can rethink about it
[4:45pm] gtorodelvalle: OK guys, I think this is it Would you be able to host the meeting tomorrow, Rik ?
[4:45pm] Rik: yup
[4:45pm] gtorodelvalle: Thanks!
|
Day 2: July 8
| Meeting Minutes
|
- 10:30 drs: ok, standup time, hi everyone
- 10:30 drs: etienne_s: here?
- 10:30 thills: hello
- 10:30 etienne_s: yep
- 10:30 drs: ok, tomorrow we'll start rotating the host
- 10:30 drs: who wants to host tomorrow?
- 10:31 drs: (or we could just rotate alphabetically)
- 10:31 drs: (so I guess I'm volunteering etienne_s)
- 10:31 drs: etienne_s: that ok?
- 10:31 etienne_s: wait we said I was out of the rotation yesterday :)
- 10:31 drs: ah, ok
- 10:31 drs: full-time dialer people only then
- 10:31 drs: that would mean gtorodelvalle will host tomorrow
- 10:32 drs: then Rik, then thills, then me again
- 10:32 drs: sound good?
- 10:32 thills: yes
- 10:32 Rik: I think the host should check that the next host is ok
- 10:32 Rik: (in case pto, holidays, etc)
- 10:32 drs: yeah, that's a good idea
- 10:33 gtorodelvalle: Are we talking about hosting this session¿
- 10:33 drs: gtorodelvalle: no, next session
- 10:33 gtorodelvalle: Yeah, but this (dialer) session
- 10:33 drs: yes
- 10:33 gtorodelvalle: ;)
- 10:33 gtorodelvalle: I can do it tomorrow
- 10:33 drs: ok, cool
- 10:33 drs: I'll write up some instructions on what to do with the wiki
- 10:33 drs: that's it for administrative stuff
- 10:33 gtorodelvalle: ;)
- 10:34 drs: so my update: I need someone to triage bug 1032502
- 10:34 firebot: https://bugzil.la/1032502 — FIXED, drs+bugzilla — [B2G][2.0][Lockscreen] The phone label of an incoming call on the lockscreen is not translated.
- 10:34 drs: it should be 1.3T+ but it never got triaged
- 10:34 drs: but that's not a big deal, as soon as it's triaged I can land it on 1.4 and 1.3T
- 10:34 etienne_s: drs: might be worth it to ni? kevin hu
- 10:34 drs: etienne_s: ok, I pinged scravag, but I'll do that instead
- 10:35 Rik: drs: it is needed for 990003 to stick on 1.4, right?
- 10:35 drs: yes
- 10:35 Rik: maybe lawrence mandel too?
- 10:35 wesley_huang has left IRC (Quit: wesley_huang)
- 10:35 drs: sure, good idea
- 10:35 drs: I'll ping him after
- 10:35 drs: other issue I want to raise, we have a new blocker: bug 1030912
- 10:35 drs: Rik has investigated it and thinks it's not a dialer issue
- 10:35 gsvelto: no, not a new blocker :(
- 10:35 firebot: https://bugzil.la/1030912 — NEW — [B2G][Dialer][Bluetooth] While in a call the Speaker icon is shown instead of the Bluetooth Headset
- 10:36 drs: I just got my hands on a bt headset a few minutes ago, so I can look into it
- 10:36 gsvelto: drs, I have one too if you need some help
- 10:36 drs: ok, thanks
- 10:36 thills: I have also
- 10:36 drs: (and my axe)
- 10:36 drs: Rik: do you want to take it? we should be certain what component it lies in
- 10:37 drs: I think it's better if I do though
- 10:37 Rik: drs: sure
- 10:37 drs: Rik: are you sure you don't have too many things to work on already? I don't mind taking it
- 10:37 Rik: gsvelto: what do you mean "not a new blocker"?
- 10:37 drs: I think he was sad
- 10:37 gsvelto: Rik, drs yes
- 10:37 Rik: drs: I'm pretty sure it's not us. I couldn't reproduce when I did the screenshot
- 10:37 drs: ok Rik I'm going to take it, we're running a bit late, etienne_s
- 10:38 drs: I'll try too then
- 10:38 etienne_s: not much on the dialer side, the loop audio competing stuff should land today, let's move on go gsvelto
- 10:38 gsvelto: for my part I've landed bug 1002327 on v1.4
- 10:38 firebot: https://bugzil.la/1002327 — FIXED, gsvelto — We are trying to get imei by dialing the number *#06# on a device, which has two sim card slots, bu
- 10:39 gsvelto: and I've got bug 1016885 ready for v1.4 too, then it's time for v2.0
- 10:39 firebot: https://bugzil.la/1016885 — FIXED, gsvelto — [Tarako][Dolphin][LMK][Youtube][USSD] Pop-up USSD message causes Youtube being killed at background
- 10:39 gsvelto: sadly I didn't have time yet to prepare a fix for bug 1019783 but it's all shaped up in my mind so it's just a matter of finding the time to put it together
- 10:39 firebot: https://bugzil.la/1019783 — REOPENED, gsvelto — Output from *#06# on FLAME DIALER used to return 2 IMEI
- 10:39 gsvelto: BTW I did some stuff unrelated to the dialer today so that's why I had less time to work on it
- 10:39 gsvelto: next is thills
- 10:40 drs: actually gtorodelvalle, but it's ok
- 10:40 drs: doesn't matter
- 10:40 thills: so, bug 1021550 is checked in by Hsin-Yi
- 10:40 gsvelto: oh, we're going alphabetically then?
- 10:40 drs: yeah, usually
- 10:40 drs: just easier
- 10:40 thills: oops, sorry
- 10:40 drs: and you always know who's next
- 10:40 drs: no worries, go ahead thills
- 10:40 drs: seems like gtorodelvalle is intermittently afk anyways
- 10:40 firebot: https://bugzil.la/1021550 — FIXED, thills — [Phone][Ring Tone] The ring tone is muted after first call used speaker.
- 10:41 gtorodelvalle: Yeah, my neighgboor connection is shitty today :(
- 10:41 drs: actually laughed
- 10:41 thills: ok, so other thing is I spent some time on bug 998147 y'day… I have an idea of how to fix it, but I will try and get some feedback on the approach shortly
- 10:41 gtorodelvalle: Sad news is that it is absolutely true :D
- 10:41 firebot: https://bugzil.la/998147 — NEW, thills — [Dialer] A Missed Call notification is given when chosing to hang up on an incoming call
- 10:42 gsvelto: BTW I found another duplicate of bug 998147, we had filed a ton apparently
- 10:42 drs: thills: ok, feel free to ping any of us when you need help. I think etienne_s would know the most about this, though
- 10:42 thills: ok, thanks, will do
- 10:42 drs: gtorodelvalle (connection permitting)
- 10:42 thills: that's it from my side
- 10:43 gtorodelvalle: Thanks!
- 10:43 gtorodelvalle: On my side I am getting nuts with https://bugzilla.mozilla.org/show_bug.cgi?id=1018283 since sometimes the tests take so much time to finish or some third party test fails that I have to rebase. This morning one was a tough one after Julien (I think) moved mock_l10n.js from the SMS app to shared and obviously System is supposed to reuse it :) So, praying to the gods this is the last rebase (nice movie title :)
- 10:43 gtorodelvalle: )
- 10:43 firebot: Bug 1018283 — REOPENED, gtorodelvalle — [Follow-up 951665] Pending visual revision and adjustments of the VR call screen when in lockscreen
- 10:43 gtorodelvalle: BTW, we are not supposed to land anything if some Travis or TBPL test fails, right? Because I was suggested this morning to do it if my patch was not related to the failing test :O
- 10:43 drs: gtorodelvalle: let's chat about that after
- 10:43 gtorodelvalle: ;)
- 10:43 gtorodelvalle: Apart from this, helping Paco with some integration tests and started working on https://bugzilla.mozilla.org/show_bug.cgi?id=977056 as mentioned by Anthony yesterday ;)
- 10:43 firebot: Bug 977056 — NEW, drs+bugzilla — [Dialer] Visual discrepancies: Call ended view under conference call participants list
- 10:44 drs: gtorodelvalle: if you've started working on it, please take it and assign it to yourself
- 10:44 drs: and put it in this sprint
- 10:44 drs: unless you suspect that you won't be done by the end of the sprint
- 10:44 gtorodelvalle: Sure! ;)
- 10:44 drs: s/assign it to yourself/set the status to assigned/
- 10:44 drs: ok thanks everyone, meeting over
- 10:44 thills: thanks
- 10:44 gsvelto: thanks, catch you tomorrow!
- 10:45 Rik: ( gsvelto could you duplicate the bug you found against 998147? )
- 10:45 Rik: wait !!!
- 10:45 gsvelto: Rik, yup
- 10:45 drs: argh sorry Rik
- 10:45 drs: I keep missing you because of op :(
- 10:45 drs: go ahead
- 10:45 drs: (and we're over-time too)
- 10:45 Rik: so my big blocker is QA on 1029581
- 10:45 Rik: eric answered but that wasn't helpful
- 10:45 drs: bug 1029581
- 10:45 firebot: https://bugzil.la/1029581 — ASSIGNED, anthony — [Dialer] Contact name is not shown in the call log after having two contacts with same number and th
- 10:46 drs: Rik: is it actually worth throwing something like that at QA? I've found the turnover is 1-2 weeks on requests like that
- 10:46 drs: it might be better to just do more extensive testing yourself
- 10:46 Rik: you can check https://etherpad.mozilla.org/comms-retrospect-demo with the content of this morning sprint planning
- 10:47 drs: I don't even ask for regressionwindow-wanted anymore, I just find it myself because it's so slow
- 10:47 Rik: that's why I needinfoed eric directly
- 10:47 drs: ok
- 10:47 Rik: the alternative is that I land in the dark
- 10:47 Rik: maybe that's what I should do
- 10:47 drs: Rik: well, you could compromise and do more testing yourself but not as much as they would
- 10:48 Rik: also, the SMS team provided lots of demos for the sprint retrospective
- 10:48 Rik: https://wiki.mozilla.org/Gaia/SMS/Scrum/4#Demos
- 10:48 Rik: that's pretty nice, so I'd say keep this in mind when fixing bugs
- 10:48 drs: Rik: yeah, I have that in my list of things to do as part of the restructuring
- 10:49 drs: it just doesn't seem too important to me at this phase, I think we should start doing it next sprint
- 10:49 Rik: if you can do a kind of "demo", even for blockers, that could give us a bigger sense of accomplishement
- 10:49 drs: yeah, but it makes the most sense to start at the same time as we begin feature work again
- 10:49 scravag: thills, drs, I have sent an email about what time is good for you to attend comms meeting once a week with everyone. Could be great to mention your prefered day also !
- 10:50 drs: scravag: wesley added a link to the retrospective etherpad, I added my preferred time there
- 10:50 drs: scravag: https://etherpad.mozilla.org/comms-retrospect-demo
- 10:50 drs: scravag: also, can you triage bug 1032502?
- 10:50 drs: (meeting actually over now btw)
|
Day 1: July 7
| Meeting Minutes
|
- 10:32 drs: so this is a really wonky time for our standup having it right after sprint planning, so I'm going to rearrange the schedule a bit and send out new invites
- 10:32 drs: but for now we'll just roll with it
- 10:32 drs: the issue was that some 1-on-1s were in the way
- 10:32 drs: but we're clearing that up
- 10:32 drs: gsvelto: do you mind starting? I need to look at my notes (just got out of my 1-on-1)
- 10:33 gsvelto: so, this time I've got good news
- 10:33 drs: oh yeah, and also we'll start rotating who runs these daily meetings, but not yet
- 10:33 gsvelto: bug 1016885 landed on master and v1.3t
- 10:33 firebot: https://bugzil.la/1016885 — FIXED, gsvelto — [Tarako][Dolphin][LMK][Youtube][USSD] Pop-up USSD message causes Youtube being killed at background
- 10:33 gsvelto: and I'm uplifting it to v1.4 too
- 10:34 gsvelto: (possibly to 2.0)
- 10:34 gsvelto: at the same time I'm preparing a relatively straightforward patch for bug 1019783
- 10:34 firebot: https://bugzil.la/1019783 — REOPENED, gsvelto — Output from *#06# on FLAME DIALER used to return 2 IMEI
- 10:34 gsvelto: once I fix the similar issue about IMEI numbers in the settings I think I'll be done with the MMI/USSD stuff for a while
- 10:34 gsvelto: and this is all, etienne_s shall you go next
- 10:35 drs: gsvelto: ok, is your next step bug 1019370?
- 10:35 etienne_s: 990003
- 10:35 firebot: https://bugzil.la/1019370 — NEW, gsvelto — [dolphin] dolphin always shows SIM 1's USSD message for Sim 2.
- 10:35 etienne_s: this is my update :)
- 10:35 drs: ok, I'll go next (good lead-in)
- 10:35 gsvelto: yes 1019370 will be fixed by the uplift
- 10:35 drs: I have a couple of followup fixes for bug 990003, l10n regressions
- 10:35 firebot: https://bugzil.la/990003 — FIXED, etienne — [Dolphin][Tarako][Perf][Dialer] It takes a long time for the call screen shows up
- 10:35 drs: bug 1032502
- 10:36 firebot: https://bugzil.la/1032502 — FIXED, drs+bugzilla — [B2G][2.0][Lockscreen] The phone label of an incoming call on the lockscreen is not translated.
- 10:36 drs: bug 1030546
- 10:36 firebot: https://bugzil.la/1030546 — FIXED, drs+bugzilla — [Emergency call] "Cancel" button is not localized
- 10:36 gsvelto: drs, sorry, I forgot bug 1002327 which is also getting uplifted to v1.4 and which will fix 1019370
- 10:36 firebot: https://bugzil.la/1002327 — FIXED, gsvelto — We are trying to get imei by dialing the number *#06# on a device, which has two sim card slots, bu
- 10:36 drs: these will have to land for bug 990003 to stick
- 10:36 drs: gsvelto: ok
- 10:36 drs: I'm going to start doing more planning again for long-term projects similar to Rik
- 10:36 drs: once I get those landed
- 10:36 drs: that's it for me
- 10:36 drs: gtorodelvalle
- 10:37 drs: hmm, seems he's afk
- 10:37 drs: ok, thills
- 10:37 thills: bug 1021550 is going go get checked in by Hsin-yi and now I'm starting to look at bug 998147
- 10:38 firebot: https://bugzil.la/1021550 — ASSIGNED, thills — [Phone][Ring Tone] The ring tone is muted after first call used speaker.
- 10:38 firebot: https://bugzil.la/998147 — NEW, thills — [Dialer] A Missed Call notification is given when chosing to hang up on an incoming call
- 10:38 gtorodelvalle: Ups, sorry, though we were not having the meeting today… Reading...
- 10:38 drs: gtorodelvalle: yeah sorry, I know it's weird with the scheduling. we'll fix that asap
- 10:38 thills: I will also keep looking at the bug 1030550. I spent some time on that, but have not figured out the root cause/fix yet
- 10:38 firebot: https://bugzil.la/1030550 — NEW, anthony — [Dialer][Bluetooth] Callscreen app sometimes calls BT command "CHLD=3" twice when it only receive on
- 10:38 drs: thills: you can add checkin-needed as the keyword
- 10:39 gtorodelvalle: On my side, I have a couple of bugs waiting for Travis and TBPL which take so much time I have had to rebase and push the patches again. Apart from this, nothing to point out :)
- 10:39 thills: drs: yes, I did that. I think I did it in the wrong place though. I'll ask you offline
- 10:39 drs: thills: sure
- 10:39 drs: thills: also is bug 1030550 something Rik can help with?
- 10:39 Rik: thills: have you seen bug 1035074 that was created to fix 1030550?
- 10:39 firebot: https://bugzil.la/1035074 — NEW, hchang — [system-message-api] SystemMessageManager makes JS Error: "this._dispatchers is null"
- 10:40 thills: drs: yes, it's actually assigned to Rik right now. I did take a look at that other bug
- 10:40 drs: thills: yeah, I mean if you looked into it and you're not sure about next steps, maybe Rik can help since he took it originally
- 10:41 thills: drs: ok, will synch with him on it
- 10:41 drs: ok, cool
- 10:41 drs: I think that's everything unless anyone has anything else
- 10:41 drs: thanks everyone
- 10:41 Rik: me !
- 10:41 drs: oh crap sorry x_x
- 10:41 Rik: (ok, I have nothing more to say than what I wrote)
- 10:41 drs: you were way at the top with op so I missed you
- 10:42 Rik: why am I op??
- 10:42 drs: haha
- 10:42 drs: oh, I added you
- 10:42 drs: I'm not sure why I'm not
- 10:42 drs: anyways, I think that's actually it now
|
Retrospective
Retrospective Etherpad
Things we did well
- Rik: Be more people :)
- drs: Our daily standup turnout has been really good. Everyone is showing up and we've been getting a lot of unblocking/helping because of it.
- drs: We did a great job knocking down the number of open blockers. Went from 16 to 4.
- thills: Completely agree that this has been extremely helpful for getting unblocked on several issues. Also, we are doing a good job keeping the meeting short.
- Rik: I like the post meeting where we kind of implicitely decided that it's a time when people are available to help
Things we could do better
- drs: For now it makes sense for Gabriele to join us in our standups and write notes on the Etherpad, but once he has cleared his dialer work we'll have to figure out something that works better for him and isn't taking as much of his time (since he's part-time with us).
- drs: We agreed to stop writing notes on the Etherpad and instead do a better job using Bugzilla statuses. We'll use IRC slightly more for talking about blocking issues.
- gtorodelvalle: These last weeks have been really painful regarding testing (Travis and TBPL). In my case, waiting for the tests took so long that when they became green I had to rebase over and over again :-( I currently have 2 bugs waiting for tests to pass. Nice color BTW to be talking about tests :O
- Rik: It's a bit outside of our team but we need to inform project and engineering management so they can escalate.
- Rik: I'd prefer to focus the daily meeting more on things that block us and what we intend to work on the next day
- Rik: We should rotate the standup daily host
Action items
- gtorodelvalle: Define a clear procedure/workflow about how to proceed regarding testing (wait for Travis to be OK?, wait for TBPL to be OK?, wait for both?, how to proceed if we detect some failing tests of third party apps?, etc.).
- gtorodelvalle: Ask the content of #fxos-dialer to be logged.
- drs: Start using ASSIGNED status correctly.
Demos