bug 1092437 - Messages app should follow text selection pattern
Got r+, although there is still some problem in selection menu, I've confirmed with George and platform side will look into it. So I will land it today and track these platform issue.
bug 1084298 - [Messages] Decoupling the all inputs query logic from DOM tree structure
Will revisit the patch again after pending for month.
bug 1109754: don't render threads as soon as we get the data
I tried a simple patch just to give a first clue whether it would be good; it was not convincing on Buri (first panel is rendered sometimes faster, sometimes slower, but always less progressively), but maybe we need to consider Flame.
Today:
will mostly continue splitting the gaia header work
Oleg
bug 1102132 - [Messages][RTL] Move the "sliding" transition back to be the same than in LTR conditions
Got r+, landed (landed a while ago)
bug 976091 - [Messages][DSDS] Show the SIM information in the message bubble
Silence from partner on v2.0 patch necessity, patch is f+'ed, so it's ready for review\landing if requested (awaiting partner confirmation).
bug 1105857 - [Messages] User doesn't receive any notification about incoming message if native modal dialog is shown
Prepared v2.0m patch using our Dialog so that now the last class-0 message is always on top as Jenny requested and it requires less code to maintain it! (in review)
Small css tweak to support new lines symbols inside dialog content + unit test updates. While working on unit tests noticed that only ~40 utils_test.js tests are run instead of ~300 because of old issue with fixture_phones.js (fixed in master). Also I don't see any Treeherder/TBPL results on v2.0m patches, do you know how to run it?
(Julien) I don't know :/ send a mail on b2g-internal ? Ok
Steve, please ping me on IRC if you have doubts/questions/proposal regarding this patch so that I can sort it out quickly :), I see that it's critical for partner.
(Steve) ok, will review it later ! thanks!
bug 1069135 - [Rose][Woodduck][Case Fail][[Comms]MMS]The "ogg" file will not show play button and save button in MMS.(5/5)
Because of the issue with utils_test above we missed some problems in this patch. Raised warning sign :)
(Steve) Thanks for discovering this and sorry for my bad :(
(Oleg) Nope, it's test problem - I wouldn't noticed that too if not that revealed failing test :)
Other:
Left feedback on Steve's refactoring patch, looks good to me.
Today:
Will handle review/feedback/need-info requests;
Will work on review comments and assigned bugs
Day 6: 15th December
Steve
bug 1092437 - Messages app should follow text selection pattern
Landed on master.
bug 1084298 - [Messages] Decoupling the all inputs query logic from DOM tree structure
Replying the feedback
Reviewing the mark read/unread selection patch. The draft part is still not handled very well. We need to consider the thread contains draft and disable the mark function if the latest is draft.
Clean up the review queue
Joined 2 groups of v3 discussion, maybe I'll simply focus on one group after some meetings.
finished splitting into individual patches; still need to test on device ;)
next step will be to write tests
Today:
will mostly continue splitting the gaia header work
Oleg
bug 1105857 - [Messages] User doesn't receive any notification about incoming message if native modal dialog is shown
Got r+, added several screenshots for Fang to review before landing. If Fang is ok - will land the patch even without "bug 1110682 - [Travis] Run tests on v2.0m branch" as it seems urgent for partner.
bug 1109745 - [Messages] Load thread_ui and activity_handler earlier when starting as an activity
Have WIP patch with "hash"-based solution (Navigator.getPanelName if precise), it improves "share" activity significantly, can't say about new and notification case - still slow because of appropriate "thread" search logic. Will ask for feedback today before writing tests (in progress).
bug 1069135 - [Rose][Woodduck][Case Fail][[Comms]MMS]The "ogg" file will not show play button and save button in MMS.(5/5)
